frankendancer: adopt agave v4.0 versioning#8945
Merged
anwayde merged 1 commit intofiredancer-io:mainfrom Mar 18, 2026
Merged
Conversation
anwayde
requested review from
alpeng-jump,
jherrera-jump,
mmcgee-jump and
ptaffet-jump
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Frankendancer (fdctl) version derivation to align with Agave v4 semantics, including prerelease encoding.
Changes:
- Add a new
with-agave.mkhelper to parse Agave semver (including prerelease tags) fromagave/Cargo.toml. - Encode Agave prerelease information into Frankendancer’s minor version and derive the patch version from the parsed Agave version numbers.
- Bump the
agavesubmodule commit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/app/fdctl/with-version.mk | Includes Agave parsing and updates Frankendancer minor/patch computation to reflect Agave v4 prerelease encoding. |
| src/app/fdctl/with-agave.mk | New Make fragment that parses Agave semver/prerelease and exposes AGAVE_VERSION_* and prerelease tag variables. |
| agave | Updates the submodule pointer to a newer Agave commit. |
Comment on lines
+27
to
+36
| # try to parse the prerelease version | ||
| SEMVER_PRERELEASE := $(word 2,$(subst -, ,$(AGAVE_VERSION))) | ||
| ifneq ($(SEMVER_PRERELEASE),) | ||
| AGAVE_PRERELEASE_STRING := $(word 1,$(subst ., ,$(SEMVER_PRERELEASE))) | ||
| AGAVE_PRERELEASE_VERSION := $(word 2,$(subst ., ,$(SEMVER_PRERELEASE))) | ||
| endif | ||
|
|
||
| # if this is a prerelease, update the patch and set the tag | ||
| ifneq ($(AGAVE_PRERELEASE_STRING),) | ||
| AGAVE_VERSION_PATCH := $(AGAVE_PRERELEASE_VERSION) |
Comment on lines
+36
to
+42
| AGAVE_VERSION_PATCH := $(AGAVE_PRERELEASE_VERSION) | ||
| ifeq ($(AGAVE_PRERELEASE_STRING),$(AGAVE_IDENTIFIER_RELEASE_CANDIDATE)) | ||
| AGAVE_PRERELEASE_TAG := $(AGAVE_ENCODE_TAG_RELEASE_CANDIDATE) | ||
| else ifeq ($(AGAVE_PRERELEASE_STRING),$(AGAVE_IDENTIFIER_BETA)) | ||
| AGAVE_PRERELEASE_TAG := $(AGAVE_ENCODE_TAG_BETA) | ||
| else ifeq ($(AGAVE_PRERELEASE_STRING),$(AGAVE_IDENTIFIER_ALPHA)) | ||
| AGAVE_PRERELEASE_TAG := $(AGAVE_ENCODE_TAG_ALPHA) |
ptaffet-jump
approved these changes
Mar 18, 2026
cmoyes-jump
pushed a commit
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.